Do not use desugared local names in tail_expr_drop_order diagnostics#157942
Open
qaijuang wants to merge 2 commits into
Open
Do not use desugared local names in tail_expr_drop_order diagnostics#157942qaijuang wants to merge 2 commits into
qaijuang wants to merge 2 commits into
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Collaborator
|
rustbot has assigned @JonathanBrouwer. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tail_expr_drop_orderlabels values using names frombody.var_debug_info.That works for user-written bindings, but
.awaitlowering also introduces a synthetic__awaiteebinding for debuginfo. This can leak into the user-facing lint diagnostic.This PR filters collected diagnostic names through
LocalDecl::from_compiler_desugaring(), so compiler-generated locals fall back to the existing#Ntemporary labels. This does not change async lowering or the__awaiteedebuginfo name itself.A user-written binding named
__awaiteeis still treated as user-written and is still shown by name.Fixes #136206