Skip to content

Eagerly fetch typeck results when linting#157928

Open
Jarcho wants to merge 4 commits into
rust-lang:mainfrom
Jarcho:eager_typeck
Open

Eagerly fetch typeck results when linting#157928
Jarcho wants to merge 4 commits into
rust-lang:mainfrom
Jarcho:eager_typeck

Conversation

@Jarcho

@Jarcho Jarcho commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

The first commit avoids running the lint visitor if all lints were filtered out. In every other case the typeck results are accessed on every body making the delayed load pointless overhead.

@rustbot

rustbot commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 15, 2026
@rustbot

rustbot commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

r? @Kivooeo

rustbot has assigned @Kivooeo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Jarcho

Jarcho commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Turns out that was load bearing for rustdoc. That's now been worked around and documented properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants