Skip to content

move rustc_type_ir Term things to term_kind.rs#157419

Open
khyperia wants to merge 1 commit into
rust-lang:mainfrom
khyperia:term_kind_rs
Open

move rustc_type_ir Term things to term_kind.rs#157419
khyperia wants to merge 1 commit into
rust-lang:mainfrom
khyperia:term_kind_rs

Conversation

@khyperia

@khyperia khyperia commented Jun 4, 2026

Copy link
Copy Markdown
Contributor
  • TyKind, AliasTy, and AliasTyKind live in ty_kind.rs
  • ConstKind, UnevaluatedConst, and UnevaluatedConstKind live in const_kind.rs
  • TermKind, AliasTerm, and AliasTermKind live in... generic_arg.rs and predicate.rs ???

create a new file, term_kind.rs, that holds TermKind, AliasTerm, and AliasTermKind

(note that Ty, Const, and Term live in rustc_middle, not rustc_type_ir)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 4, 2026
@rustbot

rustbot commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, types
  • compiler, types expanded to 73 candidates
  • Random selection from 18 candidates

@Jamesbarford

Jamesbarford commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

This looks like there is quite a lot of overlap with; #156538 ?

@khyperia

Copy link
Copy Markdown
Contributor Author

This looks like there is quite a lot of overlap with; #156538 ?

True - feel free to integrate this change with your PR (i.e. moving TermKind/AliasTermKind to term_kind.rs). Otherwise I can wait until your PR lands and rebase this one on that, totally fine either way!

@rust-bors

This comment has been minimized.

@rustbot

rustbot commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-bors

rust-bors Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #156619) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants