Tidy: disallow TODO in other in-tree projects by reddevilmidzy · Pull Request #153166 · rust-lang/rust

reddevilmidzy · 2026-02-27T04:08:47Z

Fixes: #152280
MCP: rust-lang/compiler-team#963

TODO

Add ci check to cg_clif: Add TODO checker to cg_clif rustc_codegen_cranelift#1632
Add ci check to cg_gcc: Add TODO checker to cg_gcc rustc_codegen_gcc#861

r? lcnr

src/tools/tidy/src/alphabetical.rs

compiler/rustc_codegen_gcc/tools/generate_intrinsics.py

src/tools/tidy/src/unit_tests.rs

rustbot · 2026-02-27T06:21:16Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

bjorn3 · 2026-02-27T07:28:01Z

Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.

jieyouxu · 2026-02-27T09:46:55Z

Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.

I would suggest not running full tidy against the cg_* subtrees yeah.

Also, doesn't rust-lang/compiler-team#963 only say TODO -> FIXME? Not other tidy checks? I do not think we should be enforcing other tidy rules for the cg_* subtrees.

reddevilmidzy · 2026-02-27T10:56:56Z

Ah, I overinterpreted it — my mistake. Thanks for the clarification. I’ll update it accordingly.

reddevilmidzy

I've also added a TODO check to the CI for cg_* (rust-lang/rustc_codegen_cranelift#1632, rust-lang/rustc_codegen_gcc#861).

View changes since this review

reddevilmidzy · 2026-03-07T11:53:15Z

src/tools/tidy/src/codegen.rs

I tried to add cg_* checks to style.rs, which checks TODOs in tidy, but since it also checks other things besides TODOs, I separated it into codegen.rs.

reddevilmidzy · 2026-03-07T12:15:15Z

compiler/rustc_session/src/parse.rs

    }
 }

-// todo: this function now accepts `Session` instead of `ParseSess` and should be relocated


lowercase 👀

lcnr · 2026-03-09T06:35:08Z

compiler/rustc_codegen_gcc/src/type_.rs

            .enumerate()
            .map(|(index, field)| {
-                self.context.new_field(None, *field, format!("field{}_TODO", index))
+                self.context.new_field(None, *field, format!("field{}_FIXME", index))


is that fine?

Oh, I'll check this again. Thank you

I changed TODO to FIXME and tested it and it worked.

rust-lang/rustc_codegen_gcc@d82d242

cc: @antoyo

Yes, this should be OK.

lcnr · 2026-03-09T06:37:52Z

src/tools/tidy/src/style.rs

+        let is_codegen_tidy_file = file.ends_with(codegen_file);
+        if is_codegen_tidy_file {
+            return;
+        }


a035848#diff-2877cff958f18d248fbdb0e5f924a453e3911e7e8340139125911d3bdd8e5a62R49-R53

I'm using the "TODO" character here and top line, this is the part that was added to skip TODO check

we already do it for this_file separately, can you the checks for these two?

after that r=me

reddevilmidzy · 2026-03-13T14:38:34Z

thank you for the review
@bors r=lcnr

rust-bors · 2026-03-13T14:38:37Z

@reddevilmidzy: 🔑 Insufficient privileges: not in review users

reddevilmidzy · 2026-03-13T14:39:33Z

@lcnr It's not working because I don't have permission... haha, Please roll it up.

ShoyuVanilla · 2026-03-15T18:35:02Z

Though I'm not a compiler team member, I have the permission and it would be okay for me to add this to queue as lcnr said the following 😅

after that r=me

@bors r=lcnr

rust-bors · 2026-03-15T18:35:10Z

📌 Commit e09936e has been approved by lcnr

It is now in the queue for this repository.

rust-bors · 2026-03-15T23:52:50Z

☀️ Test successful - CI
Approved by: lcnr
Duration: 3h 13m 55s
Pushing 1e21831 to main...

github-actions · 2026-03-15T23:56:14Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d27207d (parent) -> 1e21831 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1e2183119f0ee19cc26df899e26b04ad0de3475d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 2h 54m -> 2h 22m (-18.5%)
aarch64-gnu: 2h 1m -> 2h 23m (+18.1%)
dist-x86_64-apple: 2h -> 1h 41m (-15.9%)
x86_64-gnu-gcc: 1h 13m -> 1h 1m (-15.6%)
x86_64-msvc-1: 2h 43m -> 2h 20m (-14.1%)
dist-ohos-armv7: 1h 15m -> 1h 8m (-9.2%)
x86_64-mingw-2: 2h 38m -> 2h 25m (-8.3%)
dist-x86_64-illumos: 1h 47m -> 1h 38m (-8.1%)
dist-aarch64-apple: 1h 56m -> 1h 47m (-7.9%)
aarch64-gnu-llvm-21-1: 1h 2m -> 57m 18s (-7.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-03-16T00:34:52Z

Finished benchmarking commit (1e21831): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.1%, 1.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -3.5%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.5%	[-3.5%, -3.5%]	1
Improvements ✅ (secondary)	-2.9%	[-2.9%, -2.9%]	1
All ❌✅ (primary)	-3.5%	[-3.5%, -3.5%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 481.726s -> 481.243s (-0.10%)
Artifact size: 394.80 MiB -> 394.84 MiB (0.01%)

reddevilmidzy commented Feb 27, 2026

View reviewed changes

src/tools/tidy/src/alphabetical.rs Outdated Show resolved Hide resolved

compiler/rustc_codegen_gcc/tools/generate_intrinsics.py Outdated Show resolved Hide resolved

src/tools/tidy/src/unit_tests.rs Outdated Show resolved Hide resolved

rustbot assigned lcnr Feb 27, 2026

reddevilmidzy marked this pull request as ready for review February 27, 2026 06:21

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2026

reddevilmidzy marked this pull request as draft February 27, 2026 10:58

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2026

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the codegen-tidy branch from 8af1d2e to 474d3e6 Compare March 6, 2026 06:27

This was referenced Mar 7, 2026

Add TODO checker to cg_clif rust-lang/rustc_codegen_cranelift#1632

Draft

Add TODO checker to cg_gcc rust-lang/rustc_codegen_gcc#861

Draft

rust-cloud-vms bot force-pushed the codegen-tidy branch from 474d3e6 to ac17a97 Compare March 7, 2026 11:11

Change TODO in compiler to FIXME

50db919

rust-cloud-vms bot force-pushed the codegen-tidy branch 2 times, most recently from 89a1cb9 to 2617d54 Compare March 7, 2026 12:39

reddevilmidzy changed the title ~~Allow tidy check in codegen~~ Tidy: disallow TODO in other in-tree projects Mar 7, 2026

reddevilmidzy commented Mar 7, 2026

View reviewed changes

reddevilmidzy marked this pull request as ready for review March 7, 2026 12:50

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 7, 2026

This comment has been minimized.

Sign in to view

bless ui tests

b91901d

rust-cloud-vms bot force-pushed the codegen-tidy branch from 2617d54 to a035848 Compare March 7, 2026 14:38

lcnr reviewed Mar 9, 2026

View reviewed changes

Add codegen tidy check enforcing FIXME over TODO

e09936e

rust-cloud-vms bot force-pushed the codegen-tidy branch from a035848 to e09936e Compare March 13, 2026 12:26

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 15, 2026

rust-bors bot merged commit 1e21831 into rust-lang:main Mar 15, 2026
12 checks passed

rustbot added this to the 1.96.0 milestone Mar 15, 2026

rust-bors bot mentioned this pull request Mar 16, 2026

Merge fabsf16/32/64/128 into fabs::<F> #153834

Open

reddevilmidzy deleted the codegen-tidy branch March 16, 2026 00:36

Uh oh!

Conversation

reddevilmidzy commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Feb 27, 2026

Uh oh!

bjorn3 commented Feb 27, 2026

Uh oh!

jieyouxu commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reddevilmidzy commented Feb 27, 2026

Uh oh!

This comment has been minimized.

reddevilmidzy left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reddevilmidzy commented Mar 13, 2026

Uh oh!

rust-bors bot commented Mar 13, 2026

Uh oh!

reddevilmidzy commented Mar 13, 2026

Uh oh!

ShoyuVanilla commented Mar 15, 2026

Uh oh!

rust-bors bot commented Mar 15, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 15, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 15, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Mar 16, 2026

Overall result: ❌ regressions - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

reddevilmidzy commented Feb 27, 2026 •

edited

Loading

jieyouxu commented Feb 27, 2026 •

edited

Loading

reddevilmidzy left a comment •

edited by rustbot

Loading