Don't require allocas for consuming simple enums#138582
Closed
scottmcm wants to merge 3 commits intorust-lang:mainfrom
Closed
Don't require allocas for consuming simple enums#138582scottmcm wants to merge 3 commits intorust-lang:mainfrom
allocas for consuming simple enums#138582scottmcm wants to merge 3 commits intorust-lang:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
Well, 4 months later I'm finally back to this.
For example, if you pass an
Option<u32>to a function, don't immediately write it to anallocathen read it again.