Split detecting unconstructible pub structs into a new lint from dead_code#128389
Closed
mu001999 wants to merge 1 commit intorust-lang:masterfrom
Closed
Split detecting unconstructible pub structs into a new lint from dead_code#128389mu001999 wants to merge 1 commit intorust-lang:masterfrom
mu001999 wants to merge 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#125572 detects never constructed pub structs, but introduces some regressions (#126169 and #128272).
This does not fix the regressions but just split the detection into a new lint, #127104 and #128329 try to fix them.
I don't know if it is late or not for this PR. But this could at least provide a way to help silence the lint separately for current or potential future regressions.