Skip to content

Overhaul Diagnostic and DiagnosticBuilder#120576

Merged
bors merged 2 commits intorust-lang:masterfrom
nnethercote:merge-Diagnostic-DiagnosticBuilder
Feb 20, 2024
Merged

Overhaul Diagnostic and DiagnosticBuilder#120576
bors merged 2 commits intorust-lang:masterfrom
nnethercote:merge-Diagnostic-DiagnosticBuilder

Conversation

@nnethercote
Copy link
Copy Markdown
Contributor

@nnethercote nnethercote commented Feb 2, 2024

Implements the first part of rust-lang/compiler-team#722, which moves functionality and use away from Diagnostic, onto DiagnosticBuilder.

Likely follow-ups:

  • Move things around, because this PR was written to minimize diff size, so some things end up in sub-optimal places. E.g. DiagnosticBuilder has impls in both diagnostic.rs and diagnostic_builder.rs.
  • Rename Diagnostic as DiagInner and DiagnosticBuilder as Diag.

r? @davidtwco

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants