Remove Apple RNG fallbacks and simplify implementation#116319
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 24, 2023
Merged
Remove Apple RNG fallbacks and simplify implementation#116319bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have higher Apple platform requirements, the RNG code can be simplified a lot. Since
getentropystill doesn't look to be usable outside macOS this implementation:getentropyCCRandomGenerateByteswas added in iOS 8 which means that we can use it now. It andSecRandomCopyByteshave the exact same functionality, but the former has a simpler API and no longer requires libstd to link toSecurity.frameworkfor one function. Its also available in all the other target's SDKs.Why care about
getentropythen though on macOS? Well, its still much more performant. Benchmarking shows it runs at ~2x the speed ofCCRandomGenerateBytes, which makes sense since it directly pulls from the kernel vs going through its own generator etc.Semi-related to a previous, but reverted, attempt at improving this logic in #101011