Unite bless environment variables under RUSTC_BLESS#113298
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 27, 2023
Merged
Unite bless environment variables under RUSTC_BLESS#113298bors merged 1 commit intorust-lang:masterfrom
RUSTC_BLESS#113298bors merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Clippy and Miri both use an environment variable to indicate that output should be blessed, but they use different variable names. In order to improve consistency, this patch applies the following changes:
MIRI_BLESS(as used in the Miri subtree) toRUST_BLESSBLESS(as used in the Clippy subtree) toRUST_BLESSRUST_BLESSintoprepare_cargo_testso it is always available (I need this for a WIP PR)I prefer something like
RUST_BLESStoBLESSjust for a lower chance of conflict (not super common but other tools do useBLESS), but I can change it to whatever is preferred.Original discussion: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/BLESS.20env.20var.3A.20rename.20to.20CLIPPY_BLESS
r? @oli-obk
cc @flip1995