[PERF] remove pointee types from cg_ssa and cg_llvm#105412
Closed
erikdesjardins wants to merge 4 commits intorust-lang:masterfrom
Closed
[PERF] remove pointee types from cg_ssa and cg_llvm#105412erikdesjardins wants to merge 4 commits intorust-lang:masterfrom
erikdesjardins wants to merge 4 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern LLVM (15+ by default) doesn't have pointee types, so computing them is a waste of time.
This can't be merged in its current state, because:
-Cllvm-args="-opaque-pointers=0"(not sure that we should support this configuration though)Workarounds could be:
cx.type_ptr_to(|| ...compute pointee type...), closure only called in LLVM < 15 (kinda awkward)if llvm_version < 15 { cx.type_ptr_to(...compute pointee type...) } else { cx.type_i8p() }only at important callsites (might have to end up doing this)This is just to measure the max possible perf win from everything.
r? @ghost
@rustbot label S-experimental