rustdoc: Simplify modifications of effective visibility table#103010
Merged
bors merged 3 commits intorust-lang:masterfrom Oct 30, 2022
Merged
rustdoc: Simplify modifications of effective visibility table#103010bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is now obvious that rustdoc only calls
set_access_levelwith foreign def ids andAccessLevel::Public.The second commit makes one more step and separates effective visibilities coming from rustc from similar data collected by rustdoc for extern
DefIds.The original table is no longer modified and now only contains local def ids as populated by rustc.
cc #102026 @Bryanskiy