Skip to content

Avoid LLVM-deprecated Optional::hasValue#102337

Merged
bors merged 1 commit intorust-lang:masterfrom
cuviper:llvm-optional-bool
Sep 28, 2022
Merged

Avoid LLVM-deprecated Optional::hasValue#102337
bors merged 1 commit intorust-lang:masterfrom
cuviper:llvm-optional-bool

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Sep 27, 2022

LLVM 15 added Optional::has_value, and LLVM main (16) has deprecated
hasValue. However, its explicit operator bool does the same thing,
and was added long ago, so we can use that across our full LLVM range of
compatibility.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants