Add BinaryHeap::pop_if() to manual_pop_if

[max-heller]

Detects manual implementations of the newly implemented BinaryHeap::pop_if() in manual_pop_if.

I wasn't sure about how best to handle checking for the nightly feature. Could we let people compiling with nightly know that the feature is available even if they don't have it enabled?

changelog: [manual_pop_if]: detect manual implementations of BinaryHeap::pop_if()

[rustbot]

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 7 candidates
• 7 candidates expanded to 7 candidates
• Random selection from Jarcho, dswij, llogiq, samueltardieu

[max-heller]

r? samueltardieu
(since you added this lint recently)

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[samueltardieu]

I wasn't sure about how best to handle checking for the nightly feature. Could we let people compiling with nightly know that the feature is available even if they don't have it enabled?

We don't usually recommend using features, as it might make the code incompatible with stable releases. Many developers use nightly to get the latest version of the tools but aim at being stable (or lower) compatible.

[max-heller]

We don't usually recommend using features, as it might make the code incompatible with stable releases. Many developers use nightly to get the latest version of the tools but aim at being stable (or lower) compatible.

Ah yes, of course, that makes sense. It seems like it would be useful to have some sort of feature discovery, maybe an opt-in "things that could be cleanup up by enabling features that are likely-ish to be stabilized" check.

[max-heller]

@rustbot ready

[max-heller]

@rustbot ready

[samueltardieu]

Thanks