Skip to content

Unneeded wildcard imporvement#16733

Open
jcarey9149 wants to merge 5 commits intorust-lang:masterfrom
jcarey9149:unneeded_wildcard
Open

Unneeded wildcard imporvement#16733
jcarey9149 wants to merge 5 commits intorust-lang:masterfrom
jcarey9149:unneeded_wildcard

Conversation

@jcarey9149
Copy link

changelog: [unneeded_wildcard_pattern]: add support for struct constructs.

The existing lint only looks at tuples and tuplestructs. This change adds support for standard structs, looking for cases
where one or more _ immediately preceed a ... The preceeding _ members may be omitted, as they will be collected by the .. operator.

@jcarey9149 jcarey9149 marked this pull request as ready for review March 19, 2026 17:08
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 19, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2026

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

@jcarey9149
Copy link
Author

@rustbot ready

@rustbot
Copy link
Collaborator

rustbot commented Mar 21, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants