Upgrade shlex to version 2#3380
Merged
Merged
Conversation
The cc crate already upgraded to shlex 2.x. Bumping our dependency avoids having both shlex 1.x and 2.x in the lock file. This also pulls in the soundness fix in comex/rust-shlex#26, which this project was not affected by.
emilio
requested changes
Jun 3, 2026
| checksum = "5c1599538de2394445747c8cf7935946e3cc27e9625f889d979bfb2aaf569362" | ||
| dependencies = [ | ||
| "shlex", | ||
| "shlex 1.3.0", |
Contributor
There was a problem hiding this comment.
But you need to bump cc as well, right? Otherwise you get two versions of shlex
emilio
approved these changes
Jun 3, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cc crate already upgraded to shlex 2.x. Bumping our dependency avoids having both shlex 1.x and 2.x in the lock file.
This also pulls in the soundness fix in comex/rust-shlex#26, which this project was not affected by.