fix:Normalize associated types in orphan checks - #23078
Open
YUZHEthefool wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
Aug 9, 2026
| infcx.get_or_init(|| interner.infer_ctxt().build(TypingMode::non_body_analysis())); | ||
| let mut ocx = ObligationCtxt::new(infcx); | ||
| ocx.structurally_normalize_ty(&cause, param_env, ty).unwrap_or(ty) | ||
| }; |
Contributor
There was a problem hiding this comment.
Just deeply normalize once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
错误原因是当前没有在orphan-rule检查前将<() as Trait>::Assoc归一化成实际的本地类型LocalType，修复在locality遍历中结构化归一化alias同时在归一化失败时仍保持原来的保守判断。仿照原有测试的内容做了正例，fundamental包裹以及外部类型反例的最小化测试。
<The reason for the error is that <() as Trait>::Assoc is not normalized to the actual local type LocalType before orphan-rule checking. This fixes the structural normalization of alias in locality traversal while maintaining the original conservative judgment when normalization fails. Minimized tests of positive examples, fundamental packages and external type counterexamples were made based on the content of the original tests.>
Fixed: #23076