fix: Unresolved type variables shouldn't escape impl selection - #23072
Open
Wilfred wants to merge 1 commit into
Open
fix: Unresolved type variables shouldn't escape impl selection#23072Wilfred wants to merge 1 commit into
Wilfred wants to merge 1 commit into
Conversation
find_matching_impl() called resolve_vars_if_possible(), but we rely on unresolved region inference variables not escaping. Ensure that we substitute these variables. Without this fix, we can panic when trying to resolve the variable in the wrong inference context. See the new unit test. This seems to have always been wrong, but the panic only started occurring due when libcore changed in rust-lang/rust#136006. AI disclosure: Code partly written by GPT-5 Codex. I've bisected and confirmed the repro, and reviewed all the code, but possibly there's a nicer place to fix this logic.
rustbot
added
the
S-waiting-on-review
Contributor
Author
|
I encountered this panic when trying to generate SCIP for the rhai crate. |
ChayimFriedman2
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_matching_impl() called resolve_vars_if_possible(), but we rely on unresolved region inference variables not escaping. Ensure that we substitute these variables.
Without this fix, we can panic when trying to resolve the variable in the wrong inference context. See the new unit test.
This seems to have always been wrong, but the panic only started occurring due when libcore changed in
rust-lang/rust#136006.
AI disclosure: Code partly written by GPT-5 Codex. I've bisected and confirmed the repro, and reviewed all the code, but possibly there's a nicer place to fix this logic.