add support for build-dir configuration - #22944
Open
icewind1991 wants to merge 2 commits into
Open
Conversation
rustbot
added
the
S-waiting-on-review
icewind1991
force-pushed
the
add-build-dir-support
branch
from
July 28, 2026 21:06
fcbc7a9 to
f4d6148
Compare
This comment has been minimized.
This comment has been minimized.
Veykril
reviewed
Aug 8, 2026
| cmd.arg("--target-dir").arg(target_dir.as_ref()); | ||
| } | ||
| if let Some(build_dir) = self.build_dir_config.target_dir(ws_build_dir) { | ||
| cmd.env("CARGO_BUILD_BUILD_DIR", build_dir.as_ref()); |
Member
There was a problem hiding this comment.
I take it there is no flag equivalent for this? Bit weird to see target dir and build dir being configured differently
Author
There was a problem hiding this comment.
Yes, there is no flag to set the build dir at the moment
icewind1991
force-pushed
the
add-build-dir-support
branch
from
August 8, 2026 11:48
f4d6148 to
6253068
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20150
Allows for configuring a rust-analyzer specific
build-dirjust as it already allows fortarget-dir.Changes mostly consist of duplicating the existing
target-dirlogic, only the logic around setting the option for the spawned commands is different, since there is no--build-dircargo argument.Has been tested by setting
cargo.buildDir = trueand verifying that the expected subdirectory in the globally configuredbuild-diris created, and that I can runcargo checkin parallel to the RA check without running into a lock.