feat: exclude refs(find all refs) from deps and stdlib#21906
Open
Young-Flash wants to merge 4 commits intorust-lang:masterfrom
Open
feat: exclude refs(find all refs) from deps and stdlib#21906Young-Flash wants to merge 4 commits intorust-lang:masterfrom
Young-Flash wants to merge 4 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Young-Flash
changed the title
This comment has been minimized.
This comment has been minimized.
Contributor
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
ChayimFriedman2
requested changes
Apr 13, 2026
| /// whether to search for the `self` module | ||
| search_self_mod: bool, | ||
| /// categories to exclude while collecting usages | ||
| excluded_categories: ReferenceCategory, |
Contributor
There was a problem hiding this comment.
I prefer this to be included_categories.
| Some(scope) => base.intersection(scope), | ||
| } | ||
| }; | ||
| if self.exclude_library_files { |
Contributor
There was a problem hiding this comment.
It's better to do that in scope_files(). This will also handle the case you forgot in short_associated_function_fast_search().
| } | ||
| }); | ||
| }) | ||
| .filter(|decl| !(exclude_library_refs && is_library_file(sema.db, decl.nav.file_id))); |
Contributor
There was a problem hiding this comment.
No need to do that here given it's already filtered by the search.
| FileId(0) 9..12 import | ||
| FileId(0) 31..34 | ||
| "#]], | ||
| ); |
Contributor
There was a problem hiding this comment.
I think we always want the definition, even when inside a library. Only exclude other references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up #16441, close #17184