internal: Skip rustfmt test if nightly toolchain is missing#21681
Merged
lnicola merged 1 commit intorust-lang:masterfrom Feb 24, 2026
Merged
internal: Skip rustfmt test if nightly toolchain is missing#21681lnicola merged 1 commit intorust-lang:masterfrom
lnicola merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Wilfred
force-pushed
the
skip_test_on_nightly
branch
2 times, most recently
from
8995040 to
c199318
Compare
Contributor
Author
|
Argh, |
Currently the rustfmt slow test fails if you don't have a nightly toolchain installed. We install a nightly toolchain on CI, but it's a little confusing that tests can fail on a fresh checkout on a new laptop. Instead, skip this test if there's no nightly toolchain.
Wilfred
force-pushed
the
skip_test_on_nightly
branch
from
c199318 to
5752722
Compare
Member
|
This makes sense, but I don't understand why the test is green for me without an installed nightly. EDIT: because |
lnicola
approved these changes
Feb 24, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the rustfmt slow test fails if you don't have a nightly toolchain installed. We install a nightly toolchain on CI, but it's a little confusing that tests can fail on a fresh checkout on a new laptop.
Instead, skip this test if there's no nightly toolchain.
AI disclosure: Written with a little help from Claude.