Skip to content

Document diagostic attribute duplicates #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mejrs wants to merge 1 commit into from
+3 −0
Closed

Document diagostic attribute duplicates #2226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/attributes/diagnostics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,9 @@ The `note` option can appear several times, which results in several note messag
r[attributes.diagnostic.on_unimplemented.repetition]
If any of the other options appears several times the first occurrence of the relevant option specifies the actually used value. Subsequent occurrences generates a warning.

r[attributes.diagnostic.on_unimplemented.duplicates]
The `diagnostic::on_unimplemented` attribute may be used any number of times. All keys from all uses of the attribute will be used and are subject to the repetition rules.
Copy link
Copy Markdown
Contributor Author

@mejrs mejrs Apr 13, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View changes since the review

Existing prose looks like

The `cfg` attribute may be used any number of times on a form.

and

The `derive` attribute may be used any number of times on an item.

I'm not sure what I should use, or what a form is for that matter (it's not in the glossary).


r[attributes.diagnostic.on_unimplemented.unknown-keys]
A warning is generated for any unknown keys.

Expand Down
Loading