ci: normalize paths before the style ignore-file check - #5519
Open
Yasser-Ameur wants to merge 1 commit into
Open
ci: normalize paths before the style ignore-file check#5519Yasser-Ameur wants to merge 1 commit into
Yasser-Ameur wants to merge 1 commit into
Conversation
rustbot
added
A-CI
tgross35
requested changes
Sep 8, 2026
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Yasser-Ameur
marked this pull request as ready for review
September 8, 2026 23:48
glob returns `src\macros.rs` on Windows while `IGNORE_FILES` holds `src/macros.rs`, so the file the script means to skip was formatted anyway and rustfmt failed it on width. Comparing `as_posix()` fixes it, and nothing changes where paths already use forward slashes.
Yasser-Ameur
force-pushed
the
fix/style-ignore-files-windows-path-sep
branch
from
September 9, 2026 00:06
f29d76d to
8174d16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci/style.pycannot run on Windows. glob returnssrc\macros.rsandIGNORE_FILESholdssrc/macros.rs, so the file it means to skip is formattedanyway and rustfmt fails it on width.
as_posix()before the comparison. Nothing changes where paths already useforward slashes.
libc-0.2carries the same line.@rustbot label +stable-nominated