[io] Require static lifetime bound on Error#731
Open
Conaclos wants to merge 1 commit intorust-embedded:masterfrom
Open
[io] Require static lifetime bound on Error#731Conaclos wants to merge 1 commit intorust-embedded:masterfrom
Conaclos wants to merge 1 commit intorust-embedded:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires types that implement
embedded_io::Errorto have a static lifetime.This is a breaking change. However, this should not widely impact the ecosystem because most of the error types are static anyway.
Why this change?
This is basically the same rationales as d02f6db
Many crates require error types to implement
core::error::Errorand to be'static.One of the reason is because of
core::error::Error::sourcethat returns adyn core::error::Error +'static.Working with these crates and
embedded-iomakes things hard because you have to constraint theErrorassociated type on every generic functions.Here is an example:
Requiring
'staticonembedded_io::Errormakes things less tedious.Moreover, it is considered as a best practice in the Rust community of requiring both
core::error::Errorand'staticon Error types.I didn't make the change on other crates because their Error types don't implement core::error::Error (yet?).