Implement coverage feedback loop#84
Draft
tothtamas28 wants to merge 3 commits into
Draft
Conversation
This reverts commit a3bdcea. The `<coverage>` cell no longer has a huge depth, so traversing it with a default stack size should be feasible.
31 tasks
tothtamas28
force-pushed
the
coverage-loop
branch
from
d15d68c to
586cac3
Compare
tothtamas28
force-pushed
the
coverage-loop
branch
from
5f02d61 to
8a40447
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires up a real coverage feedback loop by parsing KORE output into a
kore::Patterntree and extracting data from the<coverage>cell, replacing the previous stub.Changes
get_exit_codeandwrite_coverage_datanow take&kore::Patterninstead of&kllvm::Block, dropping the regex-based string scraping.get_coverage_sizeis derived from actual coverage instead of a hardcoded100.kllvm_kore_block_dump_hotfixto trim raw dump output at the<generatedCounter>terminator, working around an upstream bug.<coverage>cell no longer has extreme nesting depth.