Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Resolves #413.
Currently, the serverless worker hardcodes the headers for webhook transmissions (
Content-Typeandcharset). When users need to secure their webhook endpoints (e.g., using a bearer token or API key to prevent unauthorized payloads), there is no built-in way to pass anAuthorizationheader back to the configured endpoint.Reproduction
RUNPOD_WEBHOOK_POST_OUTPUTpointing to an authenticated URL (e.g., expecting a Bearer token).Fix
Updated
_transmitinsiderunpod/serverless/modules/rp_http.pyto dynamically check forRUNPOD_WEBHOOK_AUTHORIZATIONorRUNPOD_WEBHOOK_HEADER_AUTHenvironment variables. If present, it injects theAuthorizationheader into the outgoing POST request payload. This allows secure endpoints without breaking backward compatibility for unauthenticated endpoints.Testing
RUNPOD_WEBHOOK_AUTHORIZATION="Bearer token"and intercepting the webhook output.