Open
Conversation
deanq
force-pushed
the
deanq-ae-2779-consolidate-cicd
branch
from
db0c338 to
7a88b16
Compare
Merge 5 scattered workflow files (CI-pytests, CI-codeql, CI-e2e, CD-publish_to_pypi, CD-test_publish_to_pypi) into 2 consolidated files (ci.yml, cd.yml). Add Makefile so local dev mirrors CI. - ci.yml: test + e2e + codeql as parallel quality gates + validation job - cd.yml: staging TestPyPI + production release-please/PyPI publish - Makefile: setup, test, build, verify, quality-check targets - Normalize setup-uv to v7 across all jobs - Disable notify-workers pending optimization (85min wasted runner time) - vhs.yml unchanged (manual only, unrelated to pipeline) Closes AE-2779
deanq
force-pushed
the
deanq-ae-2779-consolidate-cicd
branch
from
7a88b16 to
0b3e99b
Compare
There was a problem hiding this comment.
Pull request overview
Consolidates the repository’s GitHub Actions CI/CD configuration into two workflows and introduces a top-level Makefile to align local developer commands with CI execution.
Changes:
- Replaces multiple CI workflows with a single
CIworkflow containingtest,e2e,codeql, and avalidationgate job. - Replaces multiple CD workflows with a single
CDworkflow for TestPyPI (staging) and PyPI publishing (main) via release-please. - Adds a root
Makefileto standardize setup, test, coverage, build, and package verification commands.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Adds standardized local/CI commands (setup, test, test-coverage, build, verify, quality-check). |
| .github/workflows/ci.yml | New consolidated CI workflow with a validation gate over test/e2e/codeql. |
| .github/workflows/cd.yml | New consolidated CD workflow for staging TestPyPI and main PyPI publishing; notify-workers disabled. |
| .github/workflows/CI-pytests.yml | Removed in favor of ci.yml test job. |
| .github/workflows/CI-e2e.yml | Removed in favor of ci.yml e2e job. |
| .github/workflows/CI-codeql.yml | Removed in favor of ci.yml codeql job. |
| .github/workflows/CD-test_publish_to_pypi.yml | Removed in favor of cd.yml test-publish job. |
| .github/workflows/CD-publish_to_pypi.yml | Removed in favor of cd.yml release-please + pypi-publish jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Pin UV_PYTHON per matrix entry so uv uses the correct interpreter - Add always() to pypi-publish so force_publish works when release-please is skipped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.yml,cd.yml), following the flash-worker patternMakefileso local dev mirrors CI (make test,make quality-check)setup-uvto v7 across all jobsnotify-workerspending optimization (17 parallel jobs each sleeping 5min)vhs.ymlunchanged (manual only)Before/After
CI-pytests.ymlci.yml→testjobCI-codeql.ymlci.yml→codeqljobCI-e2e.ymlci.yml→e2ejobCD-publish_to_pypi.ymlcd.yml→release-please+pypi-publishCD-test_publish_to_pypi.ymlcd.yml→test-publishjobPost-merge
validationas required status check in branch protectionnotify-workersafter optimizing to single job with sequential dispatchTest plan
make testruns locallyCloses AE-2779