Fix parallel and cross-architecture builds - #21
Draft
jason-rl wants to merge 4 commits into
Draft
Conversation
There is no need to check the architecture twice. Also check for arm64 (MacOS) wherever we check for aarch64 (Linux). Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Packagers may specify a target system up front, which should be respected. The CRC extensions are not strictly necessary as there is a software fallback. Otherwise, use -mcpu=native if it works (it won't when cross-compiling) or -mcpu=generic+crc. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Declare generated libraries and headers as real build outputs, connect imported targets to their producers, and serialize only nested dependency builds to avoid multiplicative oversubscription. Preserve caller ISA flags and make bundled dependencies safely reconfigure when their recipes change. Build zstd through its CMake target and carry the Photon and DML compatibility patches in OverlayBD rather than image build scripts.
jason-rl
force-pushed
the
jason/fix-parallel-multiarch-builds
branch
from
August 25, 2026 23:06
000556a to
d09c5d1
Compare
Provide target-isolated GNU toolchains for x86_64 and arm64, pin host and target packages, and exercise both cross directions with Unix Makefiles at full outer parallelism. Also validate bundled curl, DML, and ISA-L configurations independently.
jason-rl
force-pushed
the
jason/fix-parallel-multiarch-builds
branch
from
August 25, 2026 23:25
d09c5d1 to
109bb64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows OverlayBD to build with maximum top-level parallelism without dependency-order races or multiplicative nested parallelism. It also supports and validates Linux x86_64-to-arm64 and arm64-to-x86_64 cross-compilation with target-isolated toolchains.
This carries the relevant fixes from containerd/overlaybd#369, declares generated dependency outputs and consumers explicitly, preserves caller ISA flags, and keeps compatibility patches in the OverlayBD source build rather than downstream Dockerfiles.
Validation completed:
--parallel $(nproc)actionlintandgit diff --checkWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):N/A
Please check the following list: