fix(mkfs): reserve correct htree checksum tail - #20
Merged
Conversation
adam-rl
force-pushed
the
adam/fix-ext4-htree-limit
branch
from
August 24, 2026 23:38
4460bd3 to
f7a8304
Compare
adam-rl
force-pushed
the
adam/fix-ext4-htree-limit
branch
from
August 25, 2026 01:15
f7a8304 to
d041e1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes corrupt ext4 directory indexes created when
metadata_csumis enabled. The pinned e2fsprogs fork reserved a 12-byte directory-entry checksum tail in an HTREE root, but HTREE roots use an 8-byteext2_dx_tail. On 4 KiB filesystems this wrote limit 506 where the kernel and e2fsck require 507.Adds an E2E regression that converts a directory with 1,000 entries and requires
e2fsck -fnto pass.Please check the following list: