Skip to content

Add the Light Stick Dance runner#38

Open
cbnuleehyunwoo wants to merge 3 commits into
runcat-dev:mainfrom
cbnuleehyunwoo:add-cheer-sticks-runner
Open

Add the Light Stick Dance runner#38
cbnuleehyunwoo wants to merge 3 commits into
runcat-dev:mainfrom
cbnuleehyunwoo:add-cheer-sticks-runner

Conversation

@cbnuleehyunwoo

@cbnuleehyunwoo cbnuleehyunwoo commented Jul 20, 2026

Copy link
Copy Markdown

Pull Request

Type of Change

  • Add a new runner
  • Fix or improve an existing runner
  • Other (site, docs, tooling)

Runner Summary

Adds Light Stick Dance (light-stick-dance), a cheering figure swinging a penlight in
each hand, one red and one blue.

Validation

  • 18 RGBA PNG frames, each 40×36 px, no interlacing
  • Frame archive contains only light-stick-dance-frames/light-stick-dance-frame-<N>.png,
    numbered 0–17, with no .DS_Store, __MACOSX/, or ._* entries
  • metadata.json: type is color; tags is empty (none of the known tags —
    animal, dog, object, mechanism, fitness — apply to a cheering person, matching
    how wall-breaker handles it)
  • preview.png verified as a 40×36 APNG with acTL preceding IDAT and no
    trailing bytes after IEND
  • runners/manifest.json kept sorted alphabetically, with light-stick-dance between
    lift-bro and linkage
  • Full repository validation passed on the PR branch:
    python3 .github/scripts/validate_runners.py --allOK: 35 runners passed
  • A simulated merge with the latest main (including flash-cat) also passed:
    OK: 36 runners passed

Checklist for Adding a Runner

  • All frames are PNG files named <runner-name>-frame-<N>.png (numbered from 0), with a height of exactly 36px, a width between 10px and 100px, and all frames share the same size.
  • The zip contains only the frames — no .DS_Store, __MACOSX/, or ._* entries.
  • The runner is my original work, or I hold the rights to it, and I consent to its distribution under this repository's license (Apache-2.0).
  • The runner does NOT contain third-party intellectual property (e.g., Pokémon, Mario, or other copyrighted/trademarked characters).
  • Files are placed at runners/<runner-name>/ as <runner-name>-frames.zip, metadata.json, and preview.png.
  • runners/manifest.json includes the new runner name and stays sorted alphabetically.
  • metadata.json contains the correct author, displayName, type (monochrome or color), and tags.
  • preview.png is an animated PNG (APNG), 36px tall, at most 100px wide, and animates correctly.
  • I have read CONTRIBUTING.md and followed the steps described there.

Comment thread runners/cheer-sticks/metadata.json Outdated
Comment thread runners/cheer-sticks/preview.png Outdated
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@cbnuleehyunwoo
cbnuleehyunwoo force-pushed the add-cheer-sticks-runner branch from f55edf3 to b5f761e Compare July 20, 2026 15:00

@cbnuleehyunwoo cbnuleehyunwoo left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the quick review and feedback! 😀
I will fix the frames and update the name, then push the changes shortly!

Comment thread runners/cheer-sticks/metadata.json Outdated
Comment thread runners/cheer-sticks/preview.png Outdated
Use outward-rounded shoe silhouettes while preserving the vertical fit and existing cheer-sticks slug.

Constraint: Keep the existing PR slug and 36px runner dimensions
Rejected: Rename to light-stick-dance | No explicit rename decision and it would broaden the review diff
Confidence: high
Scope-risk: narrow
Directive: Preserve clear frame-edge margins when regenerating the animation
Tested: RunnerGallery validator --all; 18-frame ZIP/APNG structure; 40x36 dimensions; occupied rows 3-32
Not-tested: Import into the RunCat Neo macOS application
Rename the contribution slug, archive paths, and manifest entry so the displayed name and distributed asset identity no longer diverge.

Constraint: Repository slugs and frame paths must use lowercase hyphen-separated names
Rejected: Change only displayName | It would retain the cheer-sticks identity in folders, archives, and imports
Confidence: high
Scope-risk: narrow
Directive: Use light-stick-dance for all future asset paths and manifest references
Tested: RunnerGallery validator --all; exhaustive old-name audit; ZIP/APNG structure; frame-byte equivalence; manifest ordering
Not-tested: Remote PR branch rename because pushing was explicitly excluded
@cbnuleehyunwoo cbnuleehyunwoo changed the title Add the cheer-sticks runner Add the Light Stick Dance runner Jul 20, 2026
@cbnuleehyunwoo
cbnuleehyunwoo requested a review from Kyome22 July 20, 2026 17:34

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking around frames 16 and 17, the blue stick seems to be sticking out of the frame and getting cut off. The red bar might also be cut off for a split second.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants