Check ruby version from lockfile for advisories - #451
Open
eliotsykes wants to merge 7 commits into
Open
Conversation
eliotsykes
force-pushed
the
audit-gemfile-ruby-version
branch
2 times, most recently
from
July 16, 2026 16:36
45a8fec to
4f79bf6
Compare
eliotsykes
force-pushed
the
audit-gemfile-ruby-version
branch
from
July 16, 2026 16:45
a04e766 to
54c45b9
Compare
Contributor
|
What about the other formatters (junit, json)? |
Contributor
Author
|
@simi Thanks for the feedback, I'll add support for the junit and json formatters. |
Contributor
Author
|
Hi @simi, json and junit formatting support has now been added |
eliotsykes
commented
Aug 3, 2026
Comment on lines
+86
to
+87
| advisory.delete(:gem) | ||
| advisory.delete(:engine) |
Contributor
Author
There was a problem hiding this comment.
This was needed to exclude these two new Advisory attributes from the JSON output.
I am avoiding adding new data to the output JSON without good reason, to reduce the risk of breaking anything that depends on this JSON having the same keys it always has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scans the ruby version in the lockfile and reports any corresponding advisories.
This should help projects already running bundler-audit become aware of new ruby security vulnerabilities and patches sooner.
@postmodern mentioned being open to checking the ruby version in
Gemfile.locksometime ago in #118If a scanned lockfile does not contain the
RUBY VERSIONmetadata, then this ruby check is silently skipped.Thanks in advance for any feedback.