Skip to content

FIX: don't drop requests that arrive before v8_roundtrip is re-entered #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamSaffron merged 1 commit into from
Aug 11, 2026
+3 −1
Merged

FIX: don't drop requests that arrive before v8_roundtrip is re-entered #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
- Unreleased
- Fix a race introduced in 0.21.4 where a request sent right after a nested dispatch (e.g. `perform_microtask_checkpoint` or a nested `call` from an attached callback) could be dropped, deadlocking the context

- 0.21.4 - 24-06-2026
- Fix stale V8 termination state after interrupts/timeouts so contexts remain usable after cancelled evaluations
- Let Ruby interrupts wake MiniRacer calls without immediately terminating V8, allowing signal traps and nested callbacks to unwind safely
Expand Down
1 change: 0 additions & 1 deletion ext/mini_racer_extension/mini_racer_extension.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,6 @@ void v8_roundtrip(Context *c, const uint8_t **p, size_t *n)
{
pthread_mutex_lock(&c->mtx);
buf_reset(&c->v8_req);
buf_reset(&c->req);
if (c->res.len)
c->res_ready = 1;
pthread_cond_signal(&c->cv);
Expand Down