Fix flaky system specs - #5653
Merged
awwaiid merged 2 commits intoAug 23, 2026
Merged
Conversation
rodrigovirgilio
changed the title
rodrigovirgilio
changed the title
Collaborator
|
@rodrigovirgilio sorry - can you please split these out? Upgrading to Rails 8.1 is a major bump that I don't want to block anything else. |
rodrigovirgilio
force-pushed
the
fix/flaky-system-tests
branch
from
August 16, 2026 22:13
a8f612e to
4c3b728
Compare
rodrigovirgilio
changed the title
rodrigovirgilio
changed the title
Contributor
Author
The split was done (#5657), but the problem with Brakeman (https://github.com/rubyforgood/human-essentials/actions/runs/31975766405/job/95234894577) is in the Rails update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flaky system tests for the account request and partner group editing flows.
The Rails 8.1 upgrade has been split out into PR #5657.