Fix IDOR in Requests and Donations controllers (5509)#5519
Merged
dorner merged 4 commits intorubyforgood:mainfrom Mar 27, 2026
Merged
Fix IDOR in Requests and Donations controllers (5509)#5519dorner merged 4 commits intorubyforgood:mainfrom
dorner merged 4 commits intorubyforgood:mainfrom
Conversation
dorner
approved these changes
Mar 20, 2026
Collaborator
|
@cassxw it looks good but is failing lint. Can you fix please? |
- Donations & Requests
dorner
approved these changes
Mar 27, 2026
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves #5509 (other controller fixes in #5514)
Description
Scopes Requests and Donations lookups to the current organization to prevent cross‑org access (IDOR). Adds request specs for cross‑org 404 behavior and updates the request show spec to use a valid default storage location.
Removes tenant isolation risk for Requests and Donations lookups.
Tradeoffs: 404s for cross‑org IDs instead of showing the record.
Type of change
How Has This Been Tested?
bundle exec rspec spec/requests/requests_requests_spec.rb spec/requests/donations_requests_spec.rb- all green.