Upgrade Ruby from 3.3.10 to 4.0.1#6803
Closed
yagosansz wants to merge 3 commits intorubyforgood:mainfrom
Closed
Conversation
Author
|
Hey folks, this is my first time completing a Ruby upgrade, if there are more things you need me to look at and test please let me know 🙏 I'll do a second pass at this and so more research on things to look out for! |
Collaborator
|
Sorry we didn't put this in the ticket but I think that the safest thing is - Please update ruby to 4.0.2 and rubygems to 4.0.6 as per heroku currently supported docs https://devcenter.heroku.com/articles/ruby-support-reference#ruby-version-support-policy |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6750
What changed, and why?
We're upgrading Ruby from 3.3.10 to 4.01.
How is this tested? (please write rspec and jest tests!) 💖💪
Note: if you see a flake in your test build in github actions, please post in slack #casa "Flaky test: " :) 💪
Note: We love capybara tests! If you are writing both haml/js and ruby, please try to test your work with tests at every level including system tests like https://github.com/rubyforgood/casa/tree/main/spec/system
I went through the app pages for the users below and did a smoke test through some of the menu options:
Screenshots please :)
Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.
Feelings gif (optional)
_What gif best describes your feeling working on this issue? https://giphy.com/
