Remove dead workshops#summary action - #2329
Open
maebeale wants to merge 1 commit into
Open
Conversation
workshops#summary has no route, no view, no policy rule, and no tests — it was unreachable and would have raised on its first authorize! call. Removing it also frees its local build_report helper and User#organization_ workshop_logs, which nothing else called. Surfaced while removing the agency_id column (#2307), whose last live reader was this dead action. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
marked this pull request as ready for review
August 22, 2026 14:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 pure dead-code removal; verified unreachable before deleting
Why
Follow-up to #2307. Removing
users.agency_idleftworkshops#summaryas the column's last (vestigial) reader, so I checked whether the action is reachable. It isn't — it's dead three ways over:resources :workshopsonly nestscomments; there is nosummaryroute.workshops/summary.html.erb, so it couldn't render.authorize! :workshop, to: :summary?targets asummary?that no policy defines, so the action would raiseNoMethodErroron its first line if ever reached.What
summaryaction.build_reporthelper (local to this controller — onlysummarycalled it;ReportsControllerhas its own).User#organization_workshop_logs(the 3-arg one) — onlysummarycalled it.organization_monthly_workshop_logsstays;ReportsControllerstill uses it.Not touched
monthly_reports/_form.html.erbstill renders_combined_workshop_log_summarywith@combined_workshop_logs, which is now simply never assigned (it was already always-nil in prod). That's legacy monthly-reports territory — separate cleanup.