Skip to content

Remove dead workshops#summary action - #2329

Open
maebeale wants to merge 1 commit into
mainfrom
maebeale/remove-dead-workshops-summary
Open

Remove dead workshops#summary action#2329
maebeale wants to merge 1 commit into
mainfrom
maebeale/remove-dead-workshops-summary

Conversation

@maebeale

@maebeale maebeale commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 3 Read 📖 pure dead-code removal; verified unreachable before deleting

Why

Follow-up to #2307. Removing users.agency_id left workshops#summary as the column's last (vestigial) reader, so I checked whether the action is reachable. It isn't — it's dead three ways over:

  • No routeresources :workshops only nests comments; there is no summary route.
  • No view — there's no workshops/summary.html.erb, so it couldn't render.
  • No policy ruleauthorize! :workshop, to: :summary? targets a summary? that no policy defines, so the action would raise NoMethodError on its first line if ever reached.
  • No tests reference it.

What

  • Removed the summary action.
  • Removed its private build_report helper (local to this controller — only summary called it; ReportsController has its own).
  • Removed User#organization_workshop_logs (the 3-arg one) — only summary called it. organization_monthly_workshop_logs stays; ReportsController still uses it.

Not touched

  • monthly_reports/_form.html.erb still renders _combined_workshop_log_summary with @combined_workshop_logs, which is now simply never assigned (it was already always-nil in prod). That's legacy monthly-reports territory — separate cleanup.

workshops#summary has no route, no view, no policy rule, and no tests —
it was unreachable and would have raised on its first authorize! call.
Removing it also frees its local build_report helper and User#organization_
workshop_logs, which nothing else called. Surfaced while removing the
agency_id column (#2307), whose last live reader was this dead action.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@maebeale
maebeale marked this pull request as ready for review August 22, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant