Merged
Conversation
Runs on every commit: - rubocop on staged .rb files only - brakeman security scan - checks for debug statements (binding.pry, byebug, etc.) - checks for merge conflict markers - blocks committing .env/secrets files Hook is auto-installed via bin/setup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pre-commit now only runs lightweight safety checks (debug statements, conflict markers, secrets). Heavier tools run before push instead. Also removes credentials.yml.enc from secrets blocklist since it's meant to be committed (it's encrypted). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/add-pre-commit-hook
branch
from
7c41c37 to
737223b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/pre-commitruns lightweight safety checks on every commit: debug statement detection, merge conflict marker detection, and secrets/env file blockingbin/pre-pushruns rubocop and brakeman before pushing — heavier checks that shouldn't slow down iterative commitsbin/setupcredentials.yml.encfrom secrets blocklist (it's encrypted and meant to be committed)Test plan
bin/setupand verify both.git/hooks/pre-commitand.git/hooks/pre-pushare installedbinding.pryand verify commit is blocked🤖 Generated with Claude Code