Skip to content

Add spec for closing the Fiber scheduler at exit #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sampokuokkanen wants to merge 2 commits into
base: master
Choose a base branch
from
+18 −4
Open

Add spec for closing the Fiber scheduler at exit #1391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6afef40
Add spec for closing the Fiber scheduler at exit
sampokuokkanen Aug 27, 2026
8c9c0f1
Refactor to make fiber_interrupt a required method on 4.1
sampokuokkanen Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions core/fiber/set_scheduler_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,12 @@
require "fiber"

describe "Fiber.scheduler" do
required_methods = [:block, :unblock, :kernel_sleep, :io_wait]
ruby_version_is "4.1" do
required_methods << :fiber_interrupt
end

it "validates the scheduler for required methods" do
required_methods = [:block, :unblock, :kernel_sleep, :io_wait]
required_methods.each do |missing_method|
scheduler = Object.new
required_methods.difference([missing_method]).each do |method|
Expand All @@ -17,7 +21,6 @@
end

it "can set and get the scheduler" do
required_methods = [:block, :unblock, :kernel_sleep, :io_wait]
scheduler = Object.new
required_methods.each do |method|
scheduler.define_singleton_method(method) {}
Expand All @@ -27,7 +30,6 @@
end

it "returns the scheduler after setting it" do
required_methods = [:block, :unblock, :kernel_sleep, :io_wait]
scheduler = Object.new
required_methods.each do |method|
scheduler.define_singleton_method(method) {}
Expand All @@ -37,7 +39,6 @@
end

it "can remove the scheduler" do
required_methods = [:block, :unblock, :kernel_sleep, :io_wait]
scheduler = Object.new
required_methods.each do |method|
scheduler.define_singleton_method(method) {}
Expand All @@ -52,4 +53,17 @@
Fiber.set_scheduler(nil)
Fiber.scheduler.should == nil
end

it "closes the scheduler at exit, before any at_exit handler runs" do
code = <<-RUBY
scheduler = Object.new
#{required_methods}.each { |m| scheduler.define_singleton_method(m) {} }
scheduler.define_singleton_method(:close) { print "c" }

at_exit { print "a" }
Fiber.set_scheduler(scheduler)
RUBY

ruby_exe(code).should == "ca"
end
end