Add specs for Fiber.current_scheduler after a Fiber terminates - #1390
Merged
ioquatix merged 1 commit intoAug 25, 2026
Merged
Conversation
The existing examples all check what a Fiber sees while it is running, so nothing covered the root Fiber once a blocking Fiber has gone away. Cover normal completion, an exception propagating out of resume, and Fiber#kill.
sampokuokkanen
added a commit
to sampokuokkanen/jruby
that referenced
this pull request
Aug 26, 2026
Fiber.current_scheduler reads the Thread's blocking count, and it drifted both ways: Fiber#resume decremented a target that exchangeWithFiber had already decremented, and the hand-back was counted twice. Account like MRI's fiber_switch instead, where each Fiber adjusts only for itself. Adds core/fiber/current_scheduler_spec.rb from ruby/spec#1388 and drops the tag added in jruby#9604. Also adds additional root Fiber specs from ruby/spec#1390.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing examples all check what a Fiber sees while it is running, so nothing covered the root Fiber once a blocking Fiber has gone away. Cover normal completion, an exception propagating out of resume, and Fiber#kill.