Skip to content

Report which locked gems have no variant for the current platform #9738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mousa96 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

Report which locked gems have no variant for the current platform #9738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/bundler/definition.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,9 @@ def materialize(dependencies)
loop do
break if incomplete_specs.empty?

Bundler.ui.debug("The lockfile does not have all gems needed for the current platform though, Bundler will still re-resolve dependencies")
Bundler.ui.debug("The lockfile does not have all gems needed for the current platform (#{Bundler.local_platform}) though, " \
"Bundler will still re-resolve dependencies. The following locked gems have no variant for it: " \
"#{incomplete_specs.map(&:full_name).join(", ")}")
sources.remote!
reresolve_without(incomplete_specs)
specs = resolve.materialize(dependencies)
Expand Down
3 changes: 2 additions & 1 deletion spec/runtime/platform_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,8 @@
gem "requires_platform_specific"
G

expect(out).to include("lockfile does not have all gems needed for the current platform")
expect(out).to include("lockfile does not have all gems needed for the current platform (x64-mingw-ucrt)")
expect(out).to include("no variant for it: platform_specific-1.0-x86-mingw32")
expect(the_bundle).to include_gem "platform_specific 1.0 x64-mingw-ucrt"
end
end
Expand Down