Append '.gemspec' extension only when it is not present.#3988
Merged
deivid-rodriguez merged 1 commit intoruby:masterfrom Oct 2, 2020
Merged
Append '.gemspec' extension only when it is not present.#3988deivid-rodriguez merged 1 commit intoruby:masterfrom
deivid-rodriguez merged 1 commit intoruby:masterfrom
Conversation
This avoids confusing messages such as: ~~~ $ gem build *.gemspec ERROR: Gemspec file not found: *.gemspec.gemspec ~~~ Please note that the `TestGemCommandsBuildCommand#test_can_find_gemspecs_without_dot_gemspec` testcase was probably wrong from the beginning, trying to apply `.gemspec` extension to `@gem.spec_name`, which already contains the extension. Fixes minor issue mentioned in ruby#3953.
Closed
Contributor
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Append '.gemspec' extension only when it is not present. (cherry picked from commit 214fefc)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Append '.gemspec' extension only when it is not present. (cherry picked from commit 214fefc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids confusing messages such as:
Please note that the
TestGemCommandsBuildCommand#test_can_find_gemspecs_without_dot_gemspectestcase was probably wrong from the beginning, trying to apply
.gemspecextension to@gem.spec_name, which already contains the extension.Fixes minor issue mentioned in #3953.