Open
Conversation
`TopLevel#parser=` was calling `update_parser_of_file` with `absolute_name`, but `@files_hash` is keyed by `relative_name`. The lookup always failed, so `@text_files_hash` was never populated and `find_text_page` always returned nil.
These tests exercise the full pipeline: parsing source files, then resolving page URLs through the server's route method. They verify that text pages (.md, .rdoc), class pages, the index, and 404s all work correctly. The text page tests would have caught the update_parser_of_file key mismatch bug.
Collaborator
|
🚀 Preview deployment available at: https://c9681a98.rdoc-6cd.pages.dev (commit: de0e722) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TopLevel#parser=was passingabsolute_nametoStore#update_parser_of_file, but@files_hashis keyed byrelative_name. The lookup always failed, so@text_files_hashwas never populated andfind_text_pagealways returned nil — making every page link in the sidebar 404.relative_nameinstead, and renamed the parameter inupdate_parser_of_filefor consistency.