Repository navigation
Remove kconv from ALUMNI_STDLIBS - #3258
Merged
Merged
Conversation
kconv is never released as a gem; its types ship with the nkf gem and
`assign_stdlib` already handles it in the dedicated
`'bigdecimal-math', 'kconv'` branch before reaching
`when *ALUMNI_STDLIBS.keys`. The entry was never read, and its `nil`
value ("no released gem ships the types yet") was inaccurate since
nkf 0.3.0 ships sig/kconv.rbs. This aligns kconv with bigdecimal-math,
which is not listed either.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kconvis never released as a gem; its type definitions ship in thesig/directory of thenkfgem (nkf >= 0.3.0includessig/kconv.rbs).LockfileGenerator#assign_stdlibalready handleskconvin the dedicatedwhen 'bigdecimal-math', 'kconv'branch, which returns beforewhen *ALUMNI_STDLIBS.keysis reached. So the"kconv" => nilentry inALUMNI_STDLIBSwas never read. Itsnilvalue, documented as "no released version of the gem ships them yet", was also inaccurate.This removes the entry so that
kconvis treated the same way asbigdecimal-math, which is not listed inALUMNI_STDLIBSeither. Libraries absorbed into a parent gem are handled only by the dedicated branch.There is no behavior change.
test_generate_lock_from_alumni_stdlib__kconvintest/rbs/collection/config_test.rbstill passes.🤖 Generated with Claude Code