Skip to content

Split parameter-driven return types into overloads #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zonuexe wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

Split parameter-driven return types into overloads #2965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/kernel.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2233,7 +2233,8 @@ module Kernel : BasicObject
#
# Raises an exception if the new process could not execute.
#
def self?.system: (String command, *String args, ?unsetenv_others: bool, ?pgroup: true | Integer, ?umask: Integer, ?in: redirect_fd, ?out: redirect_fd, ?err: redirect_fd, ?close_others: bool, ?chdir: String, ?exception: bool) -> (NilClass | FalseClass | TrueClass)
def self?.system: (String command, *String args, ?unsetenv_others: bool, ?pgroup: true | Integer, ?umask: Integer, ?in: redirect_fd, ?out: redirect_fd, ?err: redirect_fd, ?close_others: bool, ?chdir: String, ?exception: false) -> (NilClass | FalseClass | TrueClass)
| (String command, *String args, ?unsetenv_others: bool, ?pgroup: true | Integer, ?umask: Integer, ?in: redirect_fd, ?out: redirect_fd, ?err: redirect_fd, ?close_others: bool, ?chdir: String, exception: true) -> TrueClass
Copy link
Copy Markdown
Collaborator

@ksss ksss May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kernel.system has complex arguments, and its return type does not seem very important.
It is a trade-off between type accuracy and maintenance costs, but in this case, I think maintenance costs outweigh it.

| (Hash[string, string?] env, String command, *String args, ?unsetenv_others: bool, ?pgroup: true | Integer, ?umask: Integer, ?in: redirect_fd, ?out: redirect_fd, ?err: redirect_fd, ?close_others: bool, ?chdir: String, ?exception: bool) -> (NilClass | FalseClass | TrueClass)

# An interface used with `trace_var` (and `untrace_var`) for custom command types.
Expand Down
3 changes: 2 additions & 1 deletion core/thread.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1719,7 +1719,8 @@ class Thread::Queue[E = untyped] < Object
# If `timeout` seconds have passed and no data is available `nil` is returned.
# If `timeout` is `0` it returns immediately.
#
def pop: (?boolish non_block, ?timeout: _ToF?) -> E?
def pop: (?false non_block, ?timeout: _ToF?) -> E?
| (true non_block) -> E

# <!--
# rdoc-file=thread_sync.c
Expand Down
3 changes: 2 additions & 1 deletion stdlib/bigdecimal/0/big_decimal.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,7 +1238,8 @@ module Kernel
# Raises an exception if `value` evaluates to a Float and `digits` is larger
# than Float::DIG + 1.
#
def self?.BigDecimal: (real | string | BigDecimal initial, ?int digits, ?exception: bool) -> BigDecimal
def self?.BigDecimal: (real | string | BigDecimal initial, ?int digits, ?exception: true) -> BigDecimal
| (real | string | BigDecimal initial, ?int digits, exception: false) -> BigDecimal?
end

%a{annotate:rdoc:skip}
Expand Down
Loading