Conversation
The value of a `rescue` modifier is a full `stmt` in the grammar in
three of its six productions, but we parsed it as a plain expression
in every case. This rejected valid syntax such as `a rescue b, c = 1`
and accepted invalid syntax such as `a = 1 rescue not b`.
These are the relevant grammar rules:
stmt : stmt modifier_rescue stmt
| mlhs '=' mrhs_arg modifier_rescue stmt
command_rhs : command_call_value modifier_rescue stmt
arg_rhs : arg modifier_rescue arg
endless_arg : endless_arg modifier_rescue arg
endless_command : endless_command modifier_rescue arg
parse_rescue_modifier_value will now parse either a stmt or an arg
depending on the caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of a
rescuemodifier is a fullstmtin the grammar in three of its six productions, but we parsed it as a plain expression in every case. This rejected valid syntax such asa rescue b, c = 1and accepted invalid syntax such asa = 1 rescue not b.These are the relevant grammar rules:
parse_rescue_modifier_value will now parse either a stmt or an arg depending on the caller.
Supersedes #4128