[Feature #22108] Support computed hash keys with (expr): syntax#4132
Open
yertto wants to merge 1 commit into
Open
[Feature #22108] Support computed hash keys with (expr): syntax#4132yertto wants to merge 1 commit into
(expr): syntax#4132yertto wants to merge 1 commit into
Conversation
Add support for computed property keys in hash literals:
```ruby
h = { (expression): value }
```
In parse_assocs, when the default case encounters a
PM_PARENTHESES_NODE key followed by PM_TOKEN_COLON with no
intervening space, treat it as a computed hash key association.
This is the PRISM counterpart to ruby/ruby#17299, which implements
the same syntax in the CRuby parse.y parser.
Assisted-by: OpenCode 1.17.3 (opencode/big-pickle)
yertto
force-pushed
the
feature/computed-hash-keys
branch
from
025306e to
589d0ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for computed property keys in hash literals:
In parse_assocs, when the default case encounters a PM_PARENTHESES_NODE key followed by PM_TOKEN_COLON with no intervening space, treat it as a computed hash key association.
This is the PRISM counterpart to ruby/ruby#17299, which implements the same syntax in the CRuby parse.y parser.
Assisted-by: OpenCode 1.17.3 (opencode/big-pickle)