Skip to content

Keep Integer#to_json optimized and adapt the test #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 1 commit into from
Mar 26, 2026
+9 −7
Merged

Keep Integer#to_json optimized and adapt the test #966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/json/truffle_ruby/generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ def generate(obj, anIO = nil)
buf << obj.to_json(self)
end
when Integer
buf << String(obj)
buf << obj.to_s
when Symbol
if @strict
fast_serialize_string(obj.name, buf)
Expand Down Expand Up @@ -652,9 +652,7 @@ def json_transform(state)

module Integer
# Returns a JSON string representation for this Integer number.
def to_json(*)
String(self)
end
def to_json(*) to_s end
end

module Float
Expand Down
10 changes: 7 additions & 3 deletions test/json/json_generator_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,10 +504,14 @@ def to_s
end
alias_method :to_s, :to_s
end
case RUBY_PLATFORM
when "java"
case RUBY_ENGINE
when "jruby"
assert_equal bignum_to_s, JSON.generate(bignum)
else
when "truffleruby"
assert_raise(NoMethodError) do
JSON.generate(bignum)
end
when "ruby"
assert_raise(TypeError) do
JSON.generate(bignum)
end
Expand Down