Avoid extra mutable strings in TruffleRuby generator#964
Closed
eregon wants to merge 2 commits intoruby:masterfrom
Closed
Avoid extra mutable strings in TruffleRuby generator#964eregon wants to merge 2 commits intoruby:masterfrom
eregon wants to merge 2 commits intoruby:masterfrom
Conversation
…o_json method * To avoid extra unnecessary allocations. * See ruby#963
Member
|
Ok, with the second commit, but yeah, the first commit I'm afraid would cause compat issues. |
Member
Author
|
OK, I close this then and opened #965 with the second commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #963 (comment)