Skip to content

ResumableParser: fix handling of incomplete unicode escape #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 1 commit into from
Oct 12, 2026
Merged

ResumableParser: fix handling of incomplete unicode escape #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/json/ext/parser/parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,7 @@ static const signed char digit_values[256] = {
static uint32_t unescape_unicode(JSON_ParserState *state, const char *sp, const char *spe)
{
if (RB_UNLIKELY(sp > spe - 4)) {
raise_eos_error_at("incomplete unicode character escape sequence at %s", state, sp - 2);
raise_syntax_error_at("incomplete unicode character escape sequence at %s", state, sp - 2);
}

const unsigned char *p = (const unsigned char *)sp;
Expand Down
6 changes: 6 additions & 0 deletions test/json/resumable_parser_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,12 @@ def test_parse_byte_by_byte_string
assert_resumed_parsing('"te\\u2028st"')
assert_resumed_parsing(JSON.generate("te\u2028st"))
assert_resumed_parsing(JSON.generate("te \u2028 st"))

parser = JSON::ResumableParser.new
parser << '"\u12"'
assert_raise JSON::ParserError do
parser.parse
end
end

def test_parse_byte_by_byte_numbers
Expand Down
Loading