Update Ruby::Box context-mode test for per-box RubyGems#1221
Draft
st0012 wants to merge 1 commit into
Draft
Conversation
st0012
force-pushed
the
codex/update-ruby-box-context-test
branch
from
d841e82 to
46084c7
Compare
st0012
force-pushed
the
codex/update-ruby-box-context-test
branch
from
46084c7 to
4c10b96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ruby upstream changed Ruby::Box so RubyGems state is separated per box; the upstream commit says each box has its own RubyGems copy (ruby/ruby@276f0d9). On Ruby head,
TestIRB::ContextModeTest#test_context_mode_ruby_boxfailed because inherited Bundler setup evaluatedirb.gemspecinside the box and raiseduninitialized constant Gem::Specification(failed job).The latest-reline matrix resolves
relinefromruby/relinewhenWITH_LATEST_RELINE=true(Gemfile). Clearing Bundler setup without preserving the resolved require path made the Ruby 4.0/head latest-reline jobs fail to loadreline(4.0 job, head job).Solution
Clear the inherited Bundler environment for this Ruby::Box integration test while passing the resolved
relinerequire path throughRUBYLIB(commit). This keeps the existing context-mode isolation assertions focused onInteger#+behavior (commit).