Skip to content

Controller level caches #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amatsuda merged 3 commits into from
Jan 4, 2026
Merged

Controller level caches #97

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4648267
Cache root_id per Message
amatsuda Jan 4, 2026
60e1348
Cache thread query
amatsuda Jan 4, 2026
7151af8
Cache YYYYMM list per mailing list
amatsuda Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions app/controllers/messages_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,23 +39,26 @@ def show(list_name:, list_seq:)
private

def calculate_navigation_links
# Find root of current thread
root = @message
while root.parent_id
root = Message.find(root.parent_id)
# Find root of current thread (cached)
root_id = Rails.cache.fetch("message:#{@message.id}:root_id") do
root = @message
root = Message.find(root.parent_id) while root.parent_id
root.id
end

# Find previous/next thread (root messages)
@prev_thread_seq = Message.where(list_id: @list, parent_id: nil).where('id < ?', root.id).order(id: :desc).pick(:list_seq)
@next_thread_seq = Message.where(list_id: @list, parent_id: nil).where('id > ?', root.id).order(:id).pick(:list_seq)

# Get all messages in this thread
thread_messages = Message.with_recursive(
thread_msgs: [
Message.where(id: root.id),
Message.joins('inner join thread_msgs on messages.parent_id = thread_msgs.id')
]
).joins('inner join thread_msgs on thread_msgs.id = messages.id').order(:id).pluck(:id, :list_seq)
@prev_thread_seq = Message.where(list_id: @list, parent_id: nil).where('id < ?', root_id).order(id: :desc).pick(:list_seq)
@next_thread_seq = Message.where(list_id: @list, parent_id: nil).where('id > ?', root_id).order(:id).pick(:list_seq)

# Get all messages in this thread (cached)
thread_messages = Rails.cache.fetch("thread:#{root_id}:messages") do
Message.with_recursive(
thread_msgs: [
Message.where(id: root_id),
Message.joins('inner join thread_msgs on messages.parent_id = thread_msgs.id')
]
).joins('inner join thread_msgs on thread_msgs.id = messages.id').order(:id).pluck(:id, :list_seq)
end

# Find previous/next message in thread
current_index = thread_messages.index {|(id, _)| id == @message.id }
Expand All @@ -69,7 +72,10 @@ def render_threads(yyyymm: nil, q: nil)
if q
root_query.where!('body %> ?', q)
else
@yyyymms = Message.distinct.where(list_id: @list, parent_id: nil).order('yyyymm').pluck('yyyymm')
# Cache YYYYMM list per mailing list
@yyyymms = Rails.cache.fetch("list:#{@list.id}:yyyymms") do
Message.distinct.where(list_id: @list, parent_id: nil).order('yyyymm').pluck('yyyymm')
end
@yyyymm = yyyymm || @yyyymms.last
root_query.where!(yyyymm: @yyyymm)
end
Expand Down